SponsorBlock: Fixed some dumb issues related to storing video segments

app/src/main/java/org/schabi/newpipe/fragments/detail/VideoDetailFragment.java

@@ -265,7 +265,6 @@ public void onServiceConnected(final VideoPlayerImpl connectedPlayer,
                                    final MainPlayer connectedPlayerService,
                                    final boolean playAfterConnect) {
         player = connectedPlayer;
-        player.setVideoSegments(videoSegments);
 
         playerService = connectedPlayerService;
 
@@ -1156,6 +1155,7 @@ private void openMainPlayer() {
             playerService.getView().setVisibility(View.GONE);
         }
         addVideoPlayerView();
+        playerService.setVideoSegments(videoSegments);
 
         final Intent playerIntent = NavigationHelper
                 .getPlayerIntent(requireContext(), MainPlayer.class, queue, true, autoPlayEnabled);

app/src/main/java/org/schabi/newpipe/player/BasePlayer.java

@@ -117,7 +117,6 @@ public abstract class BasePlayer implements
     @NonNull
     protected final SharedPreferences mPrefs;
 
-    private boolean wereSponsorsMarked;
     private VideoSegment[] videoSegments;
 
     /*//////////////////////////////////////////////////////////////////////////
@@ -1770,13 +1769,6 @@ public VideoSegment[] getVideoSegments() {
     }
 
     public void setVideoSegments(final VideoSegment[] videoSegments) {
-        // use a flag to ignore null values later (i.e. when the video goes fullscreen)
-        // TODO: there's probably a better way to deal with stuff like that
-        if (wereSponsorsMarked) {
-            return;
-        }
-
         this.videoSegments = videoSegments;
-        wereSponsorsMarked = true;
     }
 }

app/src/main/java/org/schabi/newpipe/player/MainPlayer.java

@@ -35,6 +35,7 @@
 
 import org.schabi.newpipe.R;
 import org.schabi.newpipe.util.ThemeHelper;
+import org.schabi.newpipe.util.VideoSegment;
 
 import static org.schabi.newpipe.util.Localization.assureCorrectAppLanguage;
 
@@ -254,6 +255,10 @@ public void removeViewFromParent() {
         }
     }
 
+    public void setVideoSegments(final VideoSegment[] videoSegments) {
+        playerImpl.setVideoSegments(videoSegments);
+    }
+
 
     public class LocalBinder extends Binder {
 

app/src/main/java/org/schabi/newpipe/player/VideoPlayer.java

@@ -634,6 +634,7 @@ private void markSegments() {
         }
 
         final MarkableSeekBar markableSeekBar = (MarkableSeekBar) playbackSeekBar;
+        markableSeekBar.seekBarMarkers.clear();
 
         for (final VideoSegment segment : segments) {
             final Integer color = parseSegmentCategory(segment.category);