-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Modify v1 IAVL to work with pure-preimage queries #2
Conversation
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure I understand everything fully, but don't want you to be blocked. maybe we can review during our 1:1
This updates to be able to use the v0/legacy node db key format with the v1 interface. No impact on v1 support, it is still the default mode of operation and operates exactly as before.
Additionally, as with v0, there were two other things that needed to be adjusted to support pure preimage queries
Note that in our FPP we must also be sure to instantiate our mutable tree without a fastcache, as the fastcache uses non-preimage keys.
These changes do not affect the underlying DB layout so will be compatible with the normal usage in our non-FPP application logic (Polymerase).