replace sdcclib with sdar. sdcclib was removed in sdcc 3.9.0 #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. However, I do not want to merge this in until we have a solution for Windows. There is a bug in SDCC that prevents sdar from working well on Windows: |
|
Ah, I should've known there was a reason that you hadn't switched to sdar yet. Hopefully you can get the attention of the SDCC devs, thanks for taking the time to put the patch together. |
|
Potentially we could use a platform conditional in the Makefile instead? That way people who install SDCC 4.0 from their Linux/Mac package manager won't get an error, and Windows people can fall back to sdcclib? |
|
That seems fine to me. |
|
I fixed it by using |
domino-pl
pushed a commit
to domino-pl/wixel-sdk
that referenced
this pull request
Apr 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sdar was added in version 2.9