Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: better annotation detection #17

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

polentino
Copy link
Owner

At the moment, redacted works by just checking the name of the annotation, meaning that cases like this

final case class TestClass(@io.github.polentino.redacted.redacted name: String)

or

import io.github.polentino.redacted.{redacted => someRedacted}
final case class TestClass(@someRedacted name: String)

will NOT work. Even worse, false positives like this one might happen

package some.fakepkg

class redacted extends StaticAnnotation

// ... in another file

import some.fakepkg.redacted

final case class TestClass(@redacted name: String)

will still work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant