Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Implement CSV, IPC and NDJson in the MultiScanExec node #20648

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

coastalwhite
Copy link
Collaborator

This PR adds support for CSV, IPC and NDJson in the MultiScanExec node and, overall the makes the node way more effective and efficient. This is still all locked behind POLARS_NEW_MULTIFILE=1 and should not change normal behavior.

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars labels Jan 9, 2025
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 12.25000% with 351 lines in your changes missing coverage. Please review.

Project coverage is 78.97%. Comparing base (92fd75d) to head (7d85e6a).
Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
...polars-mem-engine/src/executors/multi_file_scan.rs 0.00% 147 Missing ⚠️
...tes/polars-mem-engine/src/executors/scan/ndjson.rs 16.92% 54 Missing ⚠️
crates/polars-mem-engine/src/executors/scan/ipc.rs 0.00% 53 Missing ⚠️
crates/polars-mem-engine/src/executors/scan/csv.rs 0.00% 42 Missing ⚠️
...es/polars-mem-engine/src/executors/scan/parquet.rs 11.11% 40 Missing ⚠️
crates/polars-mem-engine/src/planner/lp.rs 70.96% 9 Missing ⚠️
crates/polars-stream/src/nodes/io_sources/ipc.rs 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20648      +/-   ##
==========================================
- Coverage   79.00%   78.97%   -0.04%     
==========================================
  Files        1566     1557       -9     
  Lines      221034   220690     -344     
  Branches     2510     2514       +4     
==========================================
- Hits       174618   174280     -338     
+ Misses      45842    45837       -5     
+ Partials      574      573       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant