Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Incorrect flag check on is_elementwise #20646

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented Jan 9, 2025

BitFlags::contains only returns true if all bits on the right-hand side are true.

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Jan 9, 2025
@ritchie46 ritchie46 merged commit 2e0b3a3 into pola-rs:main Jan 9, 2025
23 checks passed
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.01%. Comparing base (6cd9988) to head (35d3568).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20646      +/-   ##
==========================================
- Coverage   79.01%   79.01%   -0.01%     
==========================================
  Files        1557     1557              
  Lines      220552   220551       -1     
  Branches     2514     2514              
==========================================
- Hits       174274   174269       -5     
- Misses      45705    45709       +4     
  Partials      573      573              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants