feat(python): Raise DuplicateError
if given a pyarrow Table object with duplicate column names
#20624
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20616.
We already catch this case in
read_database
(see: #18548), butread_database_uri
has exposed a more generic gremlin in frame construction frompyarrow.Table
objects (eg:connectorx
loads query results topyarrow.Table
, which gets passed topl.from_arrow
).We weren't explicitly checking the incoming
pyarrow.Table
for duplicate columns, which leads to a somewhat non-obviousShapeError
; with this PR we now raise a more helpfulDuplicateError
that explicitly refers to the column name that appears more than once.Example
🔴 Before
🟢 After