fix: AWS environment config was not loaded when credential provider was used #20611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
fix
nameexhaustion
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #20611 +/- ##
==========================================
- Coverage 79.00% 79.00% -0.01%
==========================================
Files 1566 1566
Lines 221034 221030 -4
Branches 2510 2510
==========================================
- Hits 174623 174616 -7
- Misses 45837 45840 +3
Partials 574 574 ☔ View full report in Codecov by Sentry. |
nameexhaustion
requested review from
ritchie46,
orlp and
c-peters
as code owners
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #20096
Partially reverts d75d8d9 - that PR was originally to address an issue for GCP but it also changed the code for AWS.
This should fix the issue - I couldn't reproduce the panic but I suspect that it is due to the code that is attempting to get the bucket name due to the region no longer being loaded from the environment