Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(rust): Use AtomicWaker in async engine task joiner #20604

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented Jan 7, 2025

We were waiting (potentially very long) on a locked mutex when awaiting our own executors tasks, use an atomic waker for the join instead.

@github-actions github-actions bot added performance Performance issues or improvements rust Related to Rust Polars labels Jan 7, 2025
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 0% with 21 lines in your changes missing coverage. Please review.

Project coverage is 78.96%. Comparing base (52ea381) to head (4ce424e).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-stream/src/async_executor/task.rs 0.00% 21 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #20604   +/-   ##
=======================================
  Coverage   78.95%   78.96%           
=======================================
  Files        1564     1564           
  Lines      220882   220881    -1     
  Branches     2510     2510           
=======================================
+ Hits       174401   174415   +14     
+ Misses      45906    45891   -15     
  Partials      575      575           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit e1179c8 into pola-rs:main Jan 7, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Performance issues or improvements rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants