Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Properly broadcast in sort_by #20434

Merged
merged 3 commits into from
Jan 8, 2025

Conversation

coastalwhite
Copy link
Collaborator

Fixes #7207.

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Dec 24, 2024
Copy link

codecov bot commented Dec 24, 2024

Codecov Report

Attention: Patch coverage is 74.19355% with 8 lines in your changes missing coverage. Please review.

Project coverage is 78.99%. Comparing base (92fd75d) to head (0abe2df).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-expr/src/expressions/sortby.rs 74.19% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20434      +/-   ##
==========================================
- Coverage   79.00%   78.99%   -0.01%     
==========================================
  Files        1566     1566              
  Lines      221034   221050      +16     
  Branches     2510     2510              
==========================================
+ Hits       174618   174624       +6     
- Misses      45842    45852      +10     
  Partials      574      574              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coastalwhite coastalwhite force-pushed the fix/sort-by-broadcast-7207 branch from dbf7b7d to 0abe2df Compare January 8, 2025 11:39
@ritchie46 ritchie46 merged commit 044bc51 into pola-rs:main Jan 8, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic when using arg_sort_by on literal
2 participants