Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Donation flow more fixes #1989

Merged
merged 9 commits into from
Dec 6, 2024
Merged

Conversation

sashko9807
Copy link
Member

Addresses bugs reported by #1960

@sashko9807 sashko9807 added the run tests Allows running the tests workflows for forked repos label Dec 4, 2024
Copy link

github-actions bot commented Dec 4, 2024

✅ Tests will run for this PR. Once they succeed it can be merged.

@github-actions github-actions bot removed the run tests Allows running the tests workflows for forked repos label Dec 4, 2024
@sashko9807 sashko9807 added the run tests Allows running the tests workflows for forked repos label Dec 4, 2024
@github-actions github-actions bot removed the run tests Allows running the tests workflows for forked repos label Dec 4, 2024
Copy link
Contributor

@gparlakov gparlakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - just a couple of console.log-s that need to go

We should probably add a eslint rule to prune these

const handleClick = (event: React.MouseEvent<HTMLButtonElement>) => {
console.log(event.currentTarget)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably dont need that one

@@ -56,26 +57,27 @@ export default function SocialShareListButton({
<ListItemButton
onClick={() => {
navigator.clipboard.writeText(url)
console.log(url)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

console log again - ditto

@sashko9807 sashko9807 added the run tests Allows running the tests workflows for forked repos label Dec 6, 2024
@github-actions github-actions bot removed the run tests Allows running the tests workflows for forked repos label Dec 6, 2024
@sashko9807 sashko9807 merged commit 62de3c5 into podkrepi-bg:master Dec 6, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants