Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: campaign application admin init #1867

Merged
merged 4 commits into from
Jul 5, 2024

Conversation

gparlakov
Copy link
Contributor

Motivation and context

Screenshots:

image
image

Before After
Paste screenshot Paste screenshot

Testing

Steps to test

Affected urls

Environment

New environment variables:

  • NEW_ENV_VAR: env var details

New or updated dependencies:

Dependency name Previous version Updated version Details
dependency/name v1.0.0 v2.0.0

- issue podkrepi-bg#1842
- add a admin space for the campaign applications
- only skeleton - will be fleshed out iteratively
- add admin edit campaign application
  - it will show all the steps of the stepper (create campaign application) with addition of the admin-only editable stuff
Copy link

github-actions bot commented Jun 30, 2024

✅ Tests will run for this PR. Once they succeed it can be merged.

@sashko9807 sashko9807 added the run tests Allows running the tests workflows for forked repos label Jul 1, 2024
@github-actions github-actions bot removed the run tests Allows running the tests workflows for forked repos label Jul 1, 2024
@teodorazhelyazkova
Copy link
Contributor

@gparlakov What are the credentials for the admin test account?

@sashko9807
Copy link
Member

@gparlakov What are the credentials for the admin test account?

User:[email protected]
Password:$ecurePa33

@sashko9807 sashko9807 added the run tests Allows running the tests workflows for forked repos label Jul 4, 2024
@github-actions github-actions bot removed the run tests Allows running the tests workflows for forked repos label Jul 4, 2024
@sashko9807
Copy link
Member

Perhaps it would be good to hide this section for the production environment, until everything to this is finished, to prevent confusion of non-tech people.
What do you think?

@gparlakov
Copy link
Contributor Author

gparlakov commented Jul 5, 2024

That might be a problem but since I'm not well acquainted with the team I'll defer to you for this.

I can say that there are 2 main goals of this PR:

  • get some early feedback from the team i.e. this is how I imagine it being laid out and working is it good for you or would you expect something else (this one might be harder to achieve with the page being hidden)
  • allow parallel execution of the sub-components of the page (this one is not affected by hiding the page)

And finally - we might be trying to solve too many issues with this one PR. I suggest taking it step by step and if there is some negative feedback we can always hide the menu.

@sashko9807 sashko9807 added the run tests Allows running the tests workflows for forked repos label Jul 5, 2024
@github-actions github-actions bot removed the run tests Allows running the tests workflows for forked repos label Jul 5, 2024
@sashko9807 sashko9807 merged commit e39bab4 into podkrepi-bg:master Jul 5, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants