Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Donate button from the successful campaign cards on Campaign l… #1841

Merged
merged 2 commits into from
Jun 17, 2024

Conversation

iliyan90
Copy link
Contributor

@iliyan90 iliyan90 commented Jun 2, 2024

Remove Donate button from the successful campaign cards on Campaign listing page #1778

Closes #{1778}

Copy link

github-actions bot commented Jun 2, 2024

✅ Tests will run for this PR. Once they succeed it can be merged.

{(campaignState === CampaignState.complete && !allowDonationOnComplete) || (
<DonateButton
href={routes.campaigns.oneTimeDonation(slug)}
disabled={campaignState === CampaignState.complete && !allowDonationOnComplete}
Copy link
Member

@sashko9807 sashko9807 Jun 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If DonateButton is not rendered on completed campaigns, why is the disabled state needed?

@sashko9807 sashko9807 added the run tests Allows running the tests workflows for forked repos label Jun 17, 2024
@github-actions github-actions bot removed the run tests Allows running the tests workflows for forked repos label Jun 17, 2024
@sashko9807 sashko9807 merged commit c7aa30f into podkrepi-bg:master Jun 17, 2024
11 of 12 checks passed
gparlakov pushed a commit to gparlakov/podkrepi-bg-frontend that referenced this pull request Jun 19, 2024
…bg#1841)

* Remove Donate button from the successful campaign cards on Campaign listing page podkrepi-bg#1778

* Remove disabled option and yarn format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants