Use next/image component for campaign images #1580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Tests will run for this PR. Once they succeed it can be merged. |
sashko9807
force-pushed
the
campaign-image-optimization
branch
from
a1e73d6 to
0c4d5c0
Compare
github-actions
bot
removed
the
run tests
igoychev
approved these changes
Sep 10, 2023
|
this change is also helping in reducing chances of dissapearing images like in this issue: #1549 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use next/image component for campaign card images.
Closes #{issue number}
Motivation and context
As of now we don't have a strict policy on image sizes for campaign's cards. This result in scenarios where a 1MB images are used, which affects both the user experience, and web vitals stats tremendously, as it takes some time before they are downloaded by the client.
The easiest way to solve this, is to use Next's Image component which provides, out of the box optimizations to reduce image size(such as automatically converting it to webp, and compressing it).