Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: consolidate getting started and context #44

Merged
merged 7 commits into from
May 24, 2024

Conversation

wkillerud
Copy link
Contributor

@wkillerud wkillerud commented May 23, 2024

Rework the intro somewhat and move getting started content to its own section.

Probably better to checkout the branch locally and run the server

git checkout podium-store-bridge-browser
npm install && npm start

Rework the intro somewhat and move getting started content to its
own section.
@wkillerud
Copy link
Contributor Author

Couldn't help myself now that I need to add some content for new modules 🙈

Copy link
Contributor

@leftieFriele leftieFriele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work 💯 I left some suggestions which I feel improved things, but you're free to ignore them if you don't agree 😄

Making this structural change should make getting introduced to Podium easier 💪

docs/podlet/local_development.md Outdated Show resolved Hide resolved

Consider the following very simple podlet server:
Consider the following podlet server:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like this removal of "very simple" and things like that. if we want to let the reader know something isn't "how you would do it in production", we should say that 👍

docs/podlet/local_development.md Outdated Show resolved Hide resolved
docs/podlet/local_development.md Show resolved Hide resolved
docs/podlet/podlet_to_podlet_communication.md Outdated Show resolved Hide resolved
docs/podlet/podlet_to_podlet_communication.md Outdated Show resolved Hide resolved
docs/podlet/proxying.md Outdated Show resolved Hide resolved
docs/podlet/proxying.md Outdated Show resolved Hide resolved
docs/introduction/assets.md Show resolved Hide resolved
docs/index.md Show resolved Hide resolved
@wkillerud
Copy link
Contributor Author

Redirects tested OK with npm run build && npm run serve.

@wkillerud wkillerud merged commit 1a4eafc into source May 24, 2024
2 checks passed
@wkillerud wkillerud deleted the podium-store-bridge-browser branch May 24, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants