Exit cpplint only after checking all files #64
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, cpplint exits immediately after finding an error in a single file. I have changed it so that it completes checking all the files and showing all of the errors rather than exiting on the first problematic file found.
The current design is quite inconvenient because when you have multiple files that could potentially have errors, it will only show you the errors one file at a time. If the errors in all files were showed in one go, they can be corrected in one go, and would avoid the user attempting to commit multiple times until all the files are eventually fixed.