Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit cpplint only after checking all files #64

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

r-shah22
Copy link

Currently, cpplint exits immediately after finding an error in a single file. I have changed it so that it completes checking all the files and showing all of the errors rather than exiting on the first problematic file found.

The current design is quite inconvenient because when you have multiple files that could potentially have errors, it will only show you the errors one file at a time. If the errors in all files were showed in one go, they can be corrected in one go, and would avoid the user attempting to commit multiple times until all the files are eventually fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant