Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version 0.4.0 #102

Merged
merged 1 commit into from
Jul 28, 2020
Merged

Version 0.4.0 #102

merged 1 commit into from
Jul 28, 2020

Conversation

afck
Copy link
Collaborator

@afck afck commented Mar 20, 2020

No description provided.

@afck afck requested a review from dforsten March 20, 2020 10:36
@afck afck mentioned this pull request Mar 20, 2020
Draft
@ravinderjangra
Copy link

ravinderjangra commented Jul 6, 2020 •
edited
Loading

hey @afck, @dforsten, any plan on merging this 😄 ?

@afck
Copy link
Collaborator Author

afck commented Jul 12, 2020

@igorbarinov: Can I merge this and publish version 0.4.0?

@igorbarinov
Copy link
Member

If you feel like this please do. I have no objections.

dforsten
dforsten approved these changes Jul 12, 2020
View reviewed changes
Copy link

@dforsten dforsten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@afck
Copy link
Collaborator Author

afck commented Jul 12, 2020

Looks like I still can't merge. You probably have to approve it, @igorbarinov.

@afck afck requested a review from igorbarinov July 12, 2020 14:01
@ravinderjangra
Copy link

Any update on this?

igorbarinov
igorbarinov approved these changes Jul 28, 2020
View reviewed changes
Copy link
Member

@igorbarinov igorbarinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@afck please try to merge again

@afck afck merged commit 7709462 into master Jul 28, 2020
@afck afck deleted the afck-0.4.0 branch July 28, 2020 17:33
@afck
Copy link
Collaborator Author

afck commented Jul 28, 2020

Thank you! It's published now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dforsten dforsten dforsten approved these changes

@igorbarinov igorbarinov igorbarinov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@afck @ravinderjangra @igorbarinov @dforsten