Fix physical memory error correction detection via WMI

po1vo · Aug 8, 2018 · 722514e · 722514e
1 parent 5af7359
commit 722514e
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 5 deletions.
diff --git a/Changes b/Changes
@@ -1,5 +1,10 @@
 Revision history for FusionInventory agent
 
+2.4.2 not released yet
+
+inventory:
+* Fix physical memory error correction detection via WMI under win32
+
 2.4.1 Fri, 29 Jun 2018
 
 core:

diff --git a/lib/FusionInventory/Agent/Task/Inventory/Win32/Memory.pm b/lib/FusionInventory/Agent/Task/Inventory/Win32/Memory.pm
@@ -136,7 +136,7 @@ sub _getMemories {
     foreach my $object (getWMIObjects(
         class      => 'Win32_PhysicalMemoryArray',
         properties => [ qw/
-            MemoryDevices SerialNumber PhysicalMemoryCorrection
+            MemoryDevices SerialNumber MemoryErrorCorrection
         / ]
     )) {
 
@@ -145,14 +145,14 @@ sub _getMemories {
             $memory->{SERIALNUMBER} = $object->{SerialNumber};
         }
 
-        if ($object->{PhysicalMemoryCorrection}) {
+        if ($object->{MemoryErrorCorrection}) {
             $memory->{MEMORYCORRECTION} =
                 $memoryErrorProtection[$object->{PhysicalMemoryCorrection}];
+            if ($memory->{MEMORYCORRECTION}) {
+                $memory->{DESCRIPTION} .= " (".$memory->{MEMORYCORRECTION}.")";
+            }
         }
 
-        if ($memory->{MEMORYCORRECTION}) {
-            $memory->{DESCRIPTION} .= " (".$memory->{MEMORYCORRECTION}.")";
-        }
     }
 
     return @memories;