feature(esx): servicetag & assettag support update

Support 2 ServiceTags case to cover chassis & lame board S/N inventory Updated AssetTag support
po1vo · Sep 12, 2018 · 3081521 · 3081521
1 parent 426ce5f
commit 3081521
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 13 deletions.
diff --git a/Changes b/Changes
@@ -24,6 +24,10 @@ deploy:
 * not p2p file parts are now cleaned up after job success if retention duration
   is null
 
+esx:
+* Support 2 ServiceTags case to cover chassis & lame board S/N inventory
+* Updated AssetTag support
+
 maintenance:
 * bump Maintenance task version to 1.1
 * disable Maintenance task if no maintenance module could be used

diff --git a/lib/FusionInventory/Agent/SOAP/VMware/Host.pm b/lib/FusionInventory/Agent/SOAP/VMware/Host.pm
@@ -47,31 +47,36 @@ sub getBiosInfo {
     my $hardware   = $self->{hash}[0]{hardware};
     my $biosInfo   = $hardware->{biosInfo};
     my $systemInfo = $hardware->{systemInfo};
-    my $ssn;
 
     return unless ref($biosInfo) eq 'HASH';
 
-    my $identifierValue;
+    my $bios = {
+        BDATE         => $biosInfo->{releaseDate},
+        BVERSION      => $biosInfo->{biosVersion},
+        SMODEL        => $systemInfo->{model},
+        SMANUFACTURER => $systemInfo->{vendor}
+    };
+
     if (ref($systemInfo->{otherIdentifyingInfo}) eq 'HASH') {
-        $identifierValue = $systemInfo->{otherIdentifyingInfo}->{identifierValue};
+        $bios->{ASSETTAG} = $systemInfo->{otherIdentifyingInfo}->{identifierValue};
     }
     elsif (ref($systemInfo->{otherIdentifyingInfo}) eq 'ARRAY') {
         foreach (@{$systemInfo->{otherIdentifyingInfo}}) {
             if ($_->{identifierType}->{key} eq 'ServiceTag') {
-                $ssn = $_->{identifierValue};
-                last;
+                # In the case we found more than one ServiceTag, assume there will be
+                # only two, the first being the chassis S/N, the second the system S/N
+                # This cover the case where the second is the lame board S/N
+                if ($bios->{SSN}) {
+                    $bios->{MSN} = $bios->{SSN};
+                }
+                $bios->{SSN} = $_->{identifierValue};
+            } elsif ($_->{identifierType}->{key} eq 'AssetTag') {
+                $bios->{ASSETTAG} = $_->{identifierValue};
             }
         }
     }
 
-    return {
-        BDATE         => $biosInfo->{releaseDate},
-        BVERSION      => $biosInfo->{biosVersion},
-        SMODEL        => $systemInfo->{model},
-        SMANUFACTURER => $systemInfo->{vendor},
-        ASSETTAG      => $identifierValue,
-        SSN           => $ssn
-    };
+    return $bios;
 }
 
 sub getHardwareInfo {