RS/YJ/Rule 11-6 (include only necessary codes) #1553
Merged
+246
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Indentation fix
# Conflicts: # rct229/schema/ASHRAE229.schema.json
…ace for 11-6 rule test
…-checking-tool into RS/YJ/Rule_11-6_organized
weilixu
approved these changes
Nov 12, 2024
Thank you Weili. @Jiarongx-Xie If this PR looks good to you, could you approve it to merge to develop? |
| def is_applicable(self, context, data=None): | ||
| rmd_b = context.BASELINE_0 | ||
|
|
||
| swh_dist_sys_b = find_all( |
There was a problem hiding this comment.
Minor - swh_dist_sys_b to swh_dist_sys_list_b
There was a problem hiding this comment.
Addressed
| get_swh_equipment_associated_with_each_swh_distribution_system(rmd_b) | ||
| ) | ||
|
|
||
| return {"swh_distribution_and_eq_list_b": swh_distribution_and_eq_list_b} |
There was a problem hiding this comment.
This data is not used in the following methods. Why do we want to create it here?
There was a problem hiding this comment.
Good catch. Addressed.
… into RS/YJ/Rule_11-6_organized
… into RS/YJ/Rule_11-6_organized
weilixu
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on PR #1543 comments, this PR only includes the codes related to rule 11-6. Thanks!