Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create Rule1-6 #1532

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

create Rule1-6 #1532

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e0bf48d
create Rule1-6
KarenWGard Sep 16, 2024
48a2068
Update Rule 1-6.md
KarenWGard Nov 6, 2024
5c1841a
Update Rule 1-6.md
KarenWGard Nov 19, 2024
80edcd0
Update Rule 1-6.md
KarenWGard Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions docs/section1/Rule 1-6.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@

# Section 1 - Rule 1-6

**Rule ID:** 1-6
**Rule Description:** On-site renewable energy shall not be included in the baseline building performance.
**Rule Assertion:** Baseline RMD = expected value
**Appendix G Section:** G3.11 18 Baseline

**Mandatory Rule:** True
**Evaluation Context:** Each RMD
**Function Call:**

## Applicability Check:
- All projects are applicable


## Rule Logic:
- get the baseline output schema: `output = B_RMD.output`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should check this across each orientation, unless that is captured somewhere else. I know Jackson populated the schema for things that should match across the baseline orientations. Not sure if we also did this with with output schema.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JacksonJ-KC ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was not done for the output schema but it seems like a good idea to take the same approach of adding those to the schema yaml/json and having the same rule cover them

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I addressed this by doing the following:

- look at each baseline model rotation: for rotation in [B_RMD, B_RMD_90, B_RMD_180, B_RMD_270]:``

- get the output instance: `output_instance = output.output_instance`
- set a boolean has_renewables and set it to false: `has_renewables = false`
- look at each end use result: `for end_use_result in output_instance.annual_end_use_results:`
- check if the energy source for the end_use_result is "ON_SITE_RENEWABLES": `if end_use_result.energy_source == "ON_SITE_RENEWABLES":`
- set has_renewables to true and continue to rule assertion: `has_renewables = true; CONTINUE TO RULE ASSERTION`
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we could also check if the annual_site_energy_use >0 when the energy source = on site renewables

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed

- if we get here without going to the rule assertion, continue to rule assertion: `CONTINUE TO RULE ASSERTION`

**Rule Assertion:**
- Case 1: If has_renewables is true, then FAIL: `if has_renewables == true: FAIL`
- Case 2: otherwise, there are no renewables, PASS: `else: PASS`


**Notes:**
1.

**[Back](../_toc.md)**


Loading