Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
As part of fixing #387, we did #388.
But it resulted in
useThree().set({controls: ...})
not working withthree-stdlib
as their controls don't match the types.This loosens the types a bit more so
useThree().set({controls})
can work again withthree-stdlib
controls.What
This PR loosen up the
three-stdlib
copy ofEventDispatcher
to fix that.But it requires some updates to
drei
types to work there.Checklist
DREI
This will require also updating DREI here:
Alternative solution
We revert #388 and merge three-types/three-ts-types#1398 instead.