fix: Properly scale the image when the scale prop is changed #2134
Conversation
|
@YordanIliev2002 is attempting to deploy a commit to the Poimandres Team on Vercel. A member of the Team first needs to authorize it. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
YordanIliev2002
force-pushed
the
fix/image-scale
branch
from
443f8ff to
d4a5952
Compare
|
The previous pipeline failed with an unrelated peer dependency error. Please reauthorize the workflow🙏 |
YordanIliev2002
force-pushed
the
fix/image-scale
branch
from
d4a5952 to
9241d23
Compare
|
@abernier, sorry for tagging, but I see that you ran the workflow the previous time. Could you reauthorize the workflow and hopefully merge soon? |
YordanIliev2002
force-pushed
the
fix/image-scale
branch
from
9241d23 to
a594016
Compare
|
as in Line 1 in 0ae552c |
|
added the comment |
|
🎉 This PR is included in version 9.120.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Why
Image gets skewed, when updating the
scalefield.Consider this codepen.
At first, you can see that all borders are visible. When you click on the image, it gets bigger, but it becomes skewed (the borders are no longer visible). Even resetting the
scaleback to1(by clicking) doesn't fix the skew.Before clicking
After clicking
What
Turns out, that the
useLayoutEffectis missing dependencies in the dependency array.After adding them, the issue is fixed, and the change of scale works properly.
Checklist