Merge pull request buildbot#8084 from Mic92/ruff-019

ruff: apply rule RUF019

master/buildbot/process/properties.py

@@ -364,9 +364,9 @@ def colon_tilde(mo):
             # if prop exists and is true (nonempty), use it; otherwise, use
             # repl
             prop, repl = mo.group(1, 2)
-            if prop in self.temp_vals and self.temp_vals[prop]:
+            if self.temp_vals.get(prop):
                 return self.temp_vals[prop]
-            elif prop in properties and properties[prop]:
+            elif prop in properties and properties[prop]:  # noqa: RUF019
                 return properties[prop]
             return repl
 

master/buildbot/test/util/validation.py

@@ -37,7 +37,7 @@ def validate(self, name, object):
     class __metaclass__(type):
         def __new__(mcs, name, bases, attrs):
             cls = type.__new__(mcs, name, bases, attrs)
-            if 'name' in attrs and attrs['name']:
+            if attrs.get('name'):
                 assert attrs['name'] not in validatorsByName
                 validatorsByName[attrs['name']] = cls
             return cls

master/buildbot/worker/kubernetes.py

@@ -190,7 +190,7 @@ def _get_request_kwargs(self):
 
         kwargs = {}
 
-        if "headers" in config and config["headers"]:
+        if config.get("headers"):
             kwargs.setdefault("headers", {}).update(config["headers"])
 
         auth = yield self._kube_config.getAuthorization()

master/buildbot/www/ldapuserinfo.py

@@ -191,7 +191,7 @@ def thd():
             if not res:
                 return None
             ldap_infos = res[0]['raw_attributes']
-            if self.avatarData in ldap_infos and ldap_infos[self.avatarData]:
+            if ldap_infos.get(self.avatarData):
                 data = ldap_infos[self.avatarData][0]
                 return self.findAvatarMime(data)
             return None

master/buildbot/www/rest.py

@@ -250,7 +250,7 @@ def writeError(msg, errcode=399, jsonrpccode=JSONRPC_CODES["internal_error"]):
             jsonRpcReply['id'] = id
             ep, kwargs = yield self.getEndpoint(request, method, params)
             userinfos = self.master.www.getUserInfos(request)
-            if 'anonymous' in userinfos and userinfos['anonymous']:
+            if userinfos.get('anonymous'):
                 owner = "anonymous"
             else:
                 for field in ('email', 'username', 'full_name'):