Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Helm URL to service resource #58

Conversation

maciaszczykm
Copy link
Member

No description provided.

Copy link

linear bot commented Sep 16, 2024

@maciaszczykm maciaszczykm marked this pull request as ready for review September 16, 2024 10:57
Copy link
Member

@michaeljguarino michaeljguarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor doc nit, otherwise lgtm

},
"url": schema.StringAttribute{
Optional: true,
Description: "Helm repository URL use.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this docstring should really be Helm repository URL to use.

@michaeljguarino michaeljguarino merged commit 9e3d4ab into main Sep 17, 2024
11 checks passed
@michaeljguarino michaeljguarino deleted the marcin/prod-2636-add-url-to-service-deployment-helm-schema-in-terraform branch September 17, 2024 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants