enhancement: Implement missing import state functions #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
floreks
approved these changes
Sep 11, 2024
michaeljguarino
approved these changes
Sep 11, 2024
maciaszczykm
deleted the
marcin/prod-2622-pr-automation-trigger-resource-import-not-implemented
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented
ImportStatefunction forplural_pr_automation_triggerandplural_stack_run_triggerresources.plural_pr_automation_triggerwill usepr_automation_id,pr_automation_branchas import identifier andplural_stack_run_triggerwill useid(stack ID).Resources mentioned above are write-only (
Readfunction is empty) just likeplural_rbachowever we can implement import to avoid errors like the one from the ticket. Import requires providing all required fields from config as we cannot read them from anywhere.Related docs.