Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Document Liquid template functions #35

Merged
merged 23 commits into from
Sep 23, 2024

Conversation

maciaszczykm
Copy link
Member

@maciaszczykm maciaszczykm commented Sep 19, 2024

Adds functionality to generate docs for all registered Liquid filters.

Adds tests checking if all filters are documented and if docs are up-to-date.

In order to update docs run make gen-docs. Once it will be merged I will add automation in the docs repository to pull these and show them at docs.plural.sh.

Note that not all filter functions are documented at the moment. It is done manually. Scraping them could be tricky as most of the docs live in Markdown documentation of sprig library with some filters being documented directly in the code. Besides that there are also our own functions which we add on top of that.

Copy link

linear bot commented Sep 19, 2024

@maciaszczykm maciaszczykm marked this pull request as ready for review September 23, 2024 13:32
@maciaszczykm maciaszczykm requested a review from a team September 23, 2024 13:32
Copy link
Member

@michaeljguarino michaeljguarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

@maciaszczykm maciaszczykm merged commit 4b6aa24 into main Sep 23, 2024
3 checks passed
@maciaszczykm maciaszczykm deleted the mjg/prod-2216-document-liquidtpl-template-functions branch September 23, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants