Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add anchors to name regex #1385

Merged
merged 1 commit into from
Oct 27, 2024
Merged

Add anchors to name regex #1385

merged 1 commit into from
Oct 27, 2024

Conversation

michaeljguarino
Copy link
Member

apparently validate_format doesn't default to whole-string matches, regex anchors solve for that

Test Plan

unit

Checklist

  • If required, I have updated the Plural documentation accordingly.
  • I have added tests to cover my changes.
  • I have added a meaningful title and summary to convey the impact of this PR to a user.
  • I have added relevant labels to this PR to help with categorization for release notes.

@michaeljguarino michaeljguarino added bug-fix This pull request fixes a bug hotfix labels Oct 27, 2024
@michaeljguarino michaeljguarino requested a review from a team October 27, 2024 14:19
Copy link

stoat-app bot commented Oct 27, 2024

Easy and customizable dashboards for your build system. Learn more about Stoat ↗︎

Static Hosting

Name Link Commit Status
api-coverage Visit d1eaa82
rtc-coverage Visit d1eaa82
core-coverage Visit d1eaa82
cron-coverage Visit d1eaa82
email-coverage Visit d1eaa82
worker-coverage Visit d1eaa82
api-test-results Visit d1eaa82
graphql-coverage Visit d1eaa82
rtc-test-results Visit d1eaa82
core-test-results Visit d1eaa82
cron-test-results Visit d1eaa82
email-test-results Visit d1eaa82
worker-test-results Visit d1eaa82
graphql-test-results Visit d1eaa82

Job Runtime

job runtime chart

debug

apparently validate_format doesn't default to whole-string matches, regex anchors solve for that
@michaeljguarino michaeljguarino merged commit d6939fe into master Oct 27, 2024
14 checks passed
@michaeljguarino michaeljguarino deleted the anchor-name-regex branch October 27, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix This pull request fixes a bug hotfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant