Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cloud instance validations #1356

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Conversation

michaeljguarino
Copy link
Member

  • off by one on the regex
  • create instance first so its uniq constraints fire first

Test Plan

existing

Checklist

  • If required, I have updated the Plural documentation accordingly.
  • I have added tests to cover my changes.
  • I have added a meaningful title and summary to convey the impact of this PR to a user.
  • I have added relevant labels to this PR to help with categorization for release notes.

@michaeljguarino michaeljguarino added the enhancement New feature or request label Aug 30, 2024
@michaeljguarino michaeljguarino requested a review from a team August 30, 2024 15:32
* off by one on the regex
* create instance first so its uniq constraints fire first
Copy link

stoat-app bot commented Aug 30, 2024

Easy and customizable dashboards for your build system. Learn more about Stoat ↗︎

Static Hosting

Name Link Commit Status
api-coverage Visit 6a220e9
rtc-coverage Visit 6a220e9
core-coverage Visit 6a220e9
cron-coverage Visit 6a220e9
email-coverage Visit 6a220e9
worker-coverage Visit 6a220e9
api-test-results Visit 6a220e9
graphql-coverage Visit 6a220e9
rtc-test-results Visit 6a220e9
core-test-results Visit 6a220e9
cron-test-results Visit 6a220e9
email-test-results Visit 6a220e9
worker-test-results Visit 6a220e9
graphql-test-results Visit 6a220e9

Job Runtime

job runtime chart

debug

@michaeljguarino michaeljguarino merged commit baf07c9 into master Aug 30, 2024
10 checks passed
@michaeljguarino michaeljguarino deleted the fix-some-validations branch August 30, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants