Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better cloud subdomaining #1343

Merged
merged 3 commits into from
Aug 24, 2024
Merged

Better cloud subdomaining #1343

merged 3 commits into from
Aug 24, 2024

Conversation

michaeljguarino
Copy link
Member

Summary

minor fixes

Test Plan

regression

Checklist

  • If required, I have updated the Plural documentation accordingly.
  • I have added tests to cover my changes.
  • I have added a meaningful title and summary to convey the impact of this PR to a user.
  • I have added relevant labels to this PR to help with categorization for release notes.

@michaeljguarino michaeljguarino added the bug-fix This pull request fixes a bug label Aug 24, 2024
@michaeljguarino michaeljguarino force-pushed the better-cloud-subdomaining branch 2 times, most recently from dd6125c to edec9cc Compare August 24, 2024 04:31
@michaeljguarino michaeljguarino force-pushed the better-cloud-subdomaining branch from edec9cc to 1a3c23a Compare August 24, 2024 04:37
@michaeljguarino michaeljguarino requested a review from a team August 24, 2024 04:59
@michaeljguarino michaeljguarino force-pushed the better-cloud-subdomaining branch from 1a3c23a to 1318492 Compare August 24, 2024 05:03
will write a pipeline context file here that's deployed via CD
@michaeljguarino michaeljguarino force-pushed the better-cloud-subdomaining branch from 0b730bd to e016c30 Compare August 24, 2024 14:15
@michaeljguarino michaeljguarino merged commit 6f240e0 into master Aug 24, 2024
10 checks passed
@michaeljguarino michaeljguarino deleted the better-cloud-subdomaining branch August 24, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix This pull request fixes a bug hotfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant