-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: ai from s3 #1215
Open
rauerhans
wants to merge
8
commits into
master
Choose a base branch
from
feat-ai-from-s3
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feat: ai from s3 #1215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Easy and customizable dashboards for your build system. Learn more about Stoat ↗︎ Static Hosting
Job Runtime |
michaeljguarino
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
After the dagster ETL for the plural ai vector store index is validated to work in prod, this should be merged to get the data from the pipeline sink at s3. I left the old scraper as is for now, we can certainly remove it when everything works as intended.
The storage context is now pulled from s3 so the
main.py
script needs to know where to find it and how to authenticate.IRSA should work, otherwise you'll need to set the standard AWS env vars:
AWS_ACCESS_KEY_ID
AWS_SECRET_ACCESS_KEY
The script expects the AWS path in
PLURAL_AI_INDEX_S3_PATH
in the format<bucket-name>/<path>
.Defaults to
plural-assets/dagster/plural-ai/vector_store_index
To be safe
AWS_DEFAULT_REGION
should be set to the region of the bucket.Labels
Test Plan
Checklist