Sentry: support TLS for Redis #21
Conversation
maciejp-ro
force-pushed
the
sentry-redis-tls-support
branch
from
6614ce9 to
14301b6
Compare
charts/sentry/Chart.yaml
Outdated
| @@ -39,4 +39,4 @@ maintainers: | |||
| - name: sentry-kubernetes | |||
| name: sentry | |||
| type: application | |||
| version: 19.4.0 | |||
| version: 19.4.0+1 | |||
There was a problem hiding this comment.
i'm not totally sure how helm will take to that versioning but we can check
There was a problem hiding this comment.
Helm doesn't complain (docs say it uses semver 2.0, which specifies -prerelease and +metadata suffix). I used metadata to indicate local changes.
Linter complains about it, though, and I checked semver spec - it says that metadata should be ignored when comparing versions (it's for things like build id). Using prerelease suffix (9.4.0-plural1) might calm the linter down. I'm on mobile now but feel free to push an update to check - I allowed maintainer pushes on this PR
There was a problem hiding this comment.
Managed to push the change, linter's still unhappy - and AFAIR Helm doesn't like it when you try to deploy changed chart without a version bump. I'm not sure how to proceed here, feel free to update this branch
There was a problem hiding this comment.
I think it's probably fine, just wanted to confirm helm won't bork on it
This builds on top of import from #20 and makes it possible to configure a TLS connection to Redis