-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add new binary pluralctl #531
Conversation
cmd/pluralctl/main.go
Outdated
cd.Command(plural.Plural, plural.HelmConfiguration), | ||
up.Command(plural.Plural), | ||
pr.Command(), | ||
stack.Command(plural.Plural), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these stacks from console or plural? We'd only care about the console stack commands here, and I do think they deserve a separate subcommand.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
those are plural stacks. We have console stacks in cd
subcommand
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah in that case transfer out the ones from cd
into the top-level here if possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the idea is the cli should sort of mimic the sidebar tab structure in the console ui.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will try to do this
pr.Command(), | ||
stack.Command(plural.Plural), | ||
cmdinit.Command(plural.Plural), | ||
mgmt.Command(plural.Plural), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably also keep:
profile
commandsclone
command (to help clone + decrypt repos)version
command (always useful to have)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some of the basic commands are here: https://github.com/pluralsh/plural-cli/pull/531/files#diff-784c7665274506f73ee507fdb0b07802971b16fa0ce946f3553c1d935d567bf8R31
I will add rest of the commands
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do still want a top-level login
command, not sure if it's here still from the pr (maybe cmdinit brings it in?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, the plural init
can handle login.
@michaeljguarino |
We should still keep the I think you might have gotten confused when I said to transfer commands from there, I just meant make the |
CD commands are in |
* add stable sort to helm dependencies * add new binary pluralctl * make CD commands on top level * move CD commands to CD group, remove plural login --------- Co-authored-by: michaeljguarino <[email protected]>
Summary
A new distribution of the CLI for fleet-management.
Labels
Test Plan
Checklist