Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new binary pluralctl #531

Merged
merged 5 commits into from
Aug 20, 2024
Merged

add new binary pluralctl #531

merged 5 commits into from
Aug 20, 2024

Conversation

zreigz
Copy link
Member

@zreigz zreigz commented Aug 19, 2024

Summary

A new distribution of the CLI for fleet-management.

Labels

Test Plan

Checklist

  • If required, I have updated the Plural documentation accordingly.
  • I have added tests to cover my changes.
  • I have added a meaningful title and summary to convey the impact of this PR to a user.
  • I have added relevant labels to this PR to help with categorization for release notes.

cd.Command(plural.Plural, plural.HelmConfiguration),
up.Command(plural.Plural),
pr.Command(),
stack.Command(plural.Plural),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these stacks from console or plural? We'd only care about the console stack commands here, and I do think they deserve a separate subcommand.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

those are plural stacks. We have console stacks in cd subcommand

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah in that case transfer out the ones from cd into the top-level here if possible.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the idea is the cli should sort of mimic the sidebar tab structure in the console ui.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will try to do this

pr.Command(),
stack.Command(plural.Plural),
cmdinit.Command(plural.Plural),
mgmt.Command(plural.Plural),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably also keep:

  • profile commands
  • clone command (to help clone + decrypt repos)
  • version command (always useful to have)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do still want a top-level login command, not sure if it's here still from the pr (maybe cmdinit brings it in?)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, the plural init can handle login.

@zreigz
Copy link
Member Author

zreigz commented Aug 20, 2024

@michaeljguarino
I've moved CD commands to the top level.
I had to move the plural login to the management group commands (duplicated with the CD login)

@michaeljguarino
Copy link
Member

michaeljguarino commented Aug 20, 2024

@michaeljguarino I've moved CD commands to the top level. I had to move the plural login to the management group commands (duplicated with the CD login)

We should still keep the cd commands under the cd subcommand I think, that'll prevent the need to move the login command as well.

I think you might have gotten confused when I said to transfer commands from there, I just meant make the cd stacks subcommand a stacks subcommand.

@zreigz
Copy link
Member Author

zreigz commented Aug 20, 2024

CD commands are in cd group again. The plural init can handle the login part, PTAL

@zreigz zreigz merged commit 09dbfa6 into main Aug 20, 2024
10 of 13 checks passed
@zreigz zreigz deleted the pluralctl branch August 20, 2024 14:44
michaeljguarino added a commit that referenced this pull request Aug 28, 2024
* add stable sort to helm dependencies

* add new binary pluralctl

* make CD commands on top level

* move CD commands to CD group, remove plural login

---------

Co-authored-by: michaeljguarino <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants