Better url validation on plural cd login
#503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaeljguarino
requested review from
zreigz,
floreks and
maciaszczykm
as code owners
michaeljguarino
force-pushed
the
add-url-validation
branch
from
05810ba to
e8ca6da
Compare
We currently just take these values blindly which can cause rough ux if someone puts a correct-ish url we don't expect
michaeljguarino
force-pushed
the
add-url-validation
branch
from
e8ca6da to
d1a429a
Compare
zreigz
approved these changes
Apr 10, 2024
michaeljguarino
added a commit
that referenced
this pull request
Aug 28, 2024
We currently just take these values blindly which can cause rough ux if someone puts a correct-ish url we don't expect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We currently just take these values blindly which can cause rough ux if someone puts a correct-ish url we don't expect
Test Plan
local test
Checklist