fix: properly pass arguments to template on push #447
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Our CLI has the
plural template
function which is run before a chart is pushed to Plural, as well as on the Plural server itself. It does this so that there is server side validation and to find image dependencies of helm charts. On the server the helm chart is packaged as a.tar.gz
file and thus the template command needs to load the chart from that file. Currently the template command was hardcoding a path rather than having the first argument be the path. This PR fixes this by having the first argument used for the path.Test Plan
Create a
.tar.gz
file of the istio helm chart by runninghelm package istio/helm/istio
and then runplural template istio-0.2.1.tgz --values istio/helm/istio/values.yaml.tpl
Checklist