Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: properly pass arguments to template on push #447

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Conversation

davidspek
Copy link
Contributor

Summary

Our CLI has the plural template function which is run before a chart is pushed to Plural, as well as on the Plural server itself. It does this so that there is server side validation and to find image dependencies of helm charts. On the server the helm chart is packaged as a .tar.gz file and thus the template command needs to load the chart from that file. Currently the template command was hardcoding a path rather than having the first argument be the path. This PR fixes this by having the first argument used for the path.

Test Plan

Create a .tar.gz file of the istio helm chart by running helm package istio/helm/istio and then run plural template istio-0.2.1.tgz --values istio/helm/istio/values.yaml.tpl

Checklist

  • If required, I have updated the Plural documentation accordingly.
  • I have added tests to cover my changes.
  • I have added a meaningful title and summary to convey the impact of this PR to a user.
  • I have added relevant labels to this PR to help with categorization for release notes.

@davidspek davidspek added the bug-fix This pull request fixes a bug label Sep 12, 2023
@davidspek davidspek merged commit de457f9 into main Sep 12, 2023
12 checks passed
@davidspek davidspek deleted the fix-push-template branch September 12, 2023 15:11
michaeljguarino pushed a commit that referenced this pull request Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix This pull request fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants