Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: move kubernetes version to template and add gcp unit tests #844

Merged
merged 4 commits into from
Sep 13, 2023
Merged

fix: move kubernetes version to template and add gcp unit tests #844

merged 4 commits into from
Sep 13, 2023

Conversation

floreks
Copy link
Member

@floreks floreks commented Sep 12, 2023 •
edited
Loading

Summary

  • add helm units tests for GCP provider
  • move default kubernetes version from helper file to values template

Test Plan

Locally with link

Checklist

  • No images hosted from dockerhub
  • Are dashboards present to understand the health of the application. There must be at least 1 of these
    • all databases should have dashboards
    • ideally also have at least cpu/mem utilization dashboards for webserver tier of the app
    • you can use plural from-grafana to convert a grafana dashboard found via google to our CRD
  • Are scaling runbooks present
    • all databases must have scaling runbooks
    • you can use the charts in pluralsh/module-library to accelerate this
  • do you need to add config overlays?
    • inputing secrets
    • configuring autoscaling
  • If there’s a web-facing component to the app, we need to support OIDC authentication and setting up private networks if no authentication option is viable
  • All major clouds must be supported
    • Azure
    • AWS
    • GCP

@floreks floreks marked this pull request as draft September 12, 2023 12:27
@floreks floreks self-assigned this Sep 12, 2023
@floreks floreks marked this pull request as ready for review September 13, 2023 08:48
davidspek
davidspek approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@davidspek davidspek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidspek davidspek merged commit 97d4d99 into main Sep 13, 2023
@davidspek davidspek deleted the update/capi branch September 13, 2023 09:06
@plural-bot
Copy link
Contributor

🎉 This PR is included in version 1.14.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidspek davidspek davidspek approved these changes

@maciaszczykm maciaszczykm maciaszczykm approved these changes

@michaeljguarino michaeljguarino Awaiting requested review from michaeljguarino michaeljguarino is a code owner

@rauerhans rauerhans Awaiting requested review from rauerhans

Assignees

@floreks floreks

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@floreks @plural-bot @maciaszczykm @davidspek