Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carrers page #99

Merged
merged 7 commits into from
Jul 16, 2024
Merged

Carrers page #99

merged 7 commits into from
Jul 16, 2024

Conversation

renemennab
Copy link
Contributor

No description provided.

@renemennab renemennab added the enhancement New feature or request label Jul 12, 2024
@renemennab renemennab requested a review from a team as a code owner July 12, 2024 20:16
Copy link

netlify bot commented Jul 12, 2024

Deploy Preview for plural-marketing ready!

Name Link
🔨 Latest commit 0da9987
🔍 Latest deploy log https://app.netlify.com/sites/plural-marketing/deploys/66955ce204d4970008c34a7d
😎 Deploy Preview https://deploy-preview-99--plural-marketing.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

return null
}
if (navItem?.subnav) {
if (!i) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we check the ids directly instead of using indexes for these? might be hard to debug if someone changes the order around in the future

Copy link
Contributor

@jsladerman jsladerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit above but otherwise lgtm

@renemennab renemennab merged commit ee90b80 into main Jul 16, 2024
9 checks passed
@jsladerman jsladerman deleted the carrers-page branch July 16, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants