Clarify adding users to RBAC group #370
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pluraldocs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| @@ -51,7 +51,7 @@ subjects: | |||
| name: [email protected] | |||
| ``` | |||
|
|
|||
| To add the specific user `[email protected]` identified by that email to the RBAC rules. | |||
| To add the specific user `[email protected]` identified by that email to the RBAC rules. For the purposes of this tutorial you will need to manually add the user to the Group created above by navigating to Settings > User Managment > Groups going to https://{you-console-instance}/settings/user-management/groups. Find the Edit Members tab in the group and add your member. | |||
There was a problem hiding this comment.
Isn't this already added at line 31? Maybe it should really just be a callout to make it prominent. It also isn't relevant to the ClusterRoleBinding above as that's a user binding and doesn't need the group to be created
There was a problem hiding this comment.
Fair enough but there should still be some callout given directing that the user(s) be added to the group in the console. That could go on line 31. Something like "add users to this group ..."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes PROD-3076