Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

put the guide into main deployment page #249

Merged
merged 6 commits into from
Feb 12, 2024

Conversation

rauerhans
Copy link
Collaborator

@rauerhans rauerhans commented Feb 12, 2024

Summary

create the guide page from

https://pluralsh.notion.site/Getting-Started-With-Plural-Fleet-Management-b7fa404b35244832bad98e06671799f0

Labels

Test Plan

Checklist

  • If required, I have updated the Plural documentation accordingly.
  • I have added tests to cover my changes.
  • I have added a meaningful title and summary to convey the impact of this PR to a user.
  • I have added relevant labels to this PR to help with categorization for release notes.

@rauerhans rauerhans requested a review from a team as a code owner February 12, 2024 11:10
Copy link

netlify bot commented Feb 12, 2024

Deploy Preview for pluraldocs ready!

Name Link
🔨 Latest commit 230de3d
🔍 Latest deploy log https://app.netlify.com/sites/pluraldocs/deploys/65ca27c8c2cd35000893a2f0
😎 Deploy Preview https://deploy-preview-249--pluraldocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rauerhans
Copy link
Collaborator Author

react-embed which we are using (https://github.com/pluralsh/design-system/blob/e45314b93c74708b654331077c1c6feb9a948e4c/src/markdoc/components/Embed.tsx)
interprets all mp4 files as audio, so embedding the video natively doesn't work in that format:
streamich/react-embed#866

Maybe if we store the asset as .webm it'll display correctly

@samweaver samweaver merged commit ac67789 into main Feb 12, 2024
8 of 9 checks passed
@samweaver
Copy link
Member

approved, squashed and merged

@samweaver samweaver deleted the feat-fleet-management-getting-started branch February 12, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants