feat: new modal component #635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsladerman
force-pushed
the
jake/prod-2329-build-a-new-modal-component
branch
from
5986c55 to
13a6389
Compare
|
Visit the preview URL for this PR (updated for commit 0b11006): https://pluralsh-design--pr635-jake-prod-2329-build-rdythu5h.web.app (expires Tue, 27 Aug 2024 04:39:44 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 784914c934330f8d0a9fd65c68898b3988262b7d |
jsladerman
force-pushed
the
jake/prod-2329-build-a-new-modal-component
branch
from
13a6389 to
02cea5f
Compare
maciaszczykm
approved these changes
Aug 20, 2024
michaeljguarino
approved these changes
Aug 20, 2024
|
🎉 This PR is included in version 3.66.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replaces the HonorableModal component with Radix-UI's dialog
makes our modal significantly more robust and removes the need for ModalMountTransition in the console- new modal waits for animations to finish before mounting/unmounting children
API is mostly unchanged, will need to do a small refactor on console modals that have explicitly defined widths but there's only a couple cases