feat: add vulnerabilityreports controller #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zreigz
commented
Nov 6, 2024
| } | ||
|
|
||
| return &console.VulnerabilityReportAttributes{ | ||
| ArtifactURL: nil, |
There was a problem hiding this comment.
@michaeljguarino I'm not sure how to get this.
There was a problem hiding this comment.
you would get this by concatenating registry + repository + tag/digest, in the usual docker image url format. Basically want it to be easily accessible for the ui, and also to potentially cross-ref elsewhere
zreigz
changed the title
|
@michaeljguarino everything seems to work fine PTAL |
| @@ -152,6 +167,23 @@ func (r *VulnerabilityReportReconciler) getObjectFromOwnerReference(ctx context. | |||
| } | |||
|
|
|||
| func (r *VulnerabilityReportReconciler) SetupWithManager(mgr ctrl.Manager) error { | |||
| logger := log.FromContext(r.Ctx) | |||
| r.reports = cmap.New[console.VulnerabilityReportAttributes]() | |||
| err := helpers.BackgroundPollUntilContextCancel(r.Ctx, 1*time.Minute, false, true, func(_ context.Context) (done bool, err error) { | |||
There was a problem hiding this comment.
make this poll interval 10 minutes i think
michaeljguarino
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.