Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: create fips binary for deployment operator #308

Merged
merged 18 commits into from
Nov 6, 2024
Merged

feat: create fips binary for deployment operator #308

merged 18 commits into from
Nov 6, 2024

Conversation

zreigz
Copy link
Member

@zreigz zreigz commented Oct 29, 2024 •
edited
Loading

  • create a GO image with FIPS support
  • use go-fips image to build the agent

github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 29, 2024
View reviewed changes
dockerfiles/agent/fips.Dockerfile Fixed Show fixed Hide fixed
dockerfiles/agent/fips.Dockerfile Fixed Show fixed Hide fixed
dockerfiles/fips/go.Dockerfile Fixed Show fixed Hide fixed
dockerfiles/fips/go.Dockerfile Fixed Show fixed Hide fixed
dockerfiles/fips/go.Dockerfile Fixed Show fixed Hide fixed
dockerfiles/fips/go.Dockerfile Fixed Show fixed Hide fixed
dockerfiles/fips/go.Dockerfile Fixed Show fixed Hide fixed
dockerfiles/fips/go.Dockerfile Fixed Show fixed Hide fixed
@zreigz zreigz changed the title create fips binary for deployment operator feat: create fips binary for deployment operator Oct 29, 2024
@zreigz zreigz added the enhancement New feature or request label Oct 29, 2024
@zreigz zreigz changed the title feat: create fips binary for deployment operator wip: create fips binary for deployment operator Oct 29, 2024
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 30, 2024
View reviewed changes
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trivy found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 30, 2024
View reviewed changes
dockerfiles/fips/go.Dockerfile Fixed Show fixed Hide fixed
dockerfiles/fips/go.Dockerfile Fixed Show fixed Hide fixed
dockerfiles/fips/go.Dockerfile Fixed Show fixed Hide fixed
dockerfiles/fips/go.Dockerfile Fixed Show fixed Hide fixed
dockerfiles/fips/go.Dockerfile Fixed Show fixed Hide fixed
@zreigz zreigz changed the title wip: create fips binary for deployment operator feat: create fips binary for deployment operator Oct 30, 2024
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 31, 2024
View reviewed changes
dockerfiles/agent/fips.Dockerfile
@@ -0,0 +1,45 @@
ARG UBI_MINIMAL_VERSION="latest"

Check notice

Code scanning / Trivy

No HEALTHCHECK defined Low

Artifact: dockerfiles/agent/fips.Dockerfile
Type: dockerfile
Vulnerability DS026
Severity: LOW
Message: Add HEALTHCHECK instruction in your Dockerfile
Link: DS026
dockerfiles/harness/fips.ansible.Dockerfile Fixed Show fixed Hide fixed
dockerfiles/harness/fips.ansible.Dockerfile Fixed Show fixed Hide fixed
dockerfiles/harness/fips.ansible.Dockerfile Fixed Show fixed Hide fixed
dockerfiles/harness/fips.base.Dockerfile Fixed Show fixed Hide fixed
dockerfiles/harness/fips.base.Dockerfile Fixed Show fixed Hide fixed
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 31, 2024
View reviewed changes
dockerfiles/harness/ansible.fips.Dockerfile
@@ -0,0 +1,49 @@
ARG HARNESS_BASE_IMAGE_TAG=latest

Check notice

Code scanning / Trivy

No HEALTHCHECK defined Low

Artifact: dockerfiles/harness/ansible.fips.Dockerfile
Type: dockerfile
Vulnerability DS026
Severity: LOW
Message: Add HEALTHCHECK instruction in your Dockerfile
Link: DS026
dockerfiles/harness/ansible.fips.Dockerfile Fixed Show fixed Hide fixed
dockerfiles/harness/ansible.fips.Dockerfile
FROM deployment-agent-fips:latest as agent

# Build Ansible from Python Image
FROM registry.access.redhat.com/ubi8/ubi:latest as final

Check warning

Code scanning / Trivy

':latest' tag used Medium

Artifact: dockerfiles/harness/ansible.fips.Dockerfile
Type: dockerfile
Vulnerability DS001
Severity: MEDIUM
Message: Specify a tag in the 'FROM' statement for image 'registry.access.redhat.com/ubi8/ubi'
Link: DS001
dockerfiles/harness/base.fips.Dockerfile
@@ -0,0 +1,55 @@
ARG GO_FIPS_IMAGE_TAG=1.23.2

Check notice

Code scanning / Trivy

No HEALTHCHECK defined Low

Artifact: dockerfiles/harness/base.fips.Dockerfile
Type: dockerfile
Vulnerability DS026
Severity: LOW
Message: Add HEALTHCHECK instruction in your Dockerfile
Link: DS026
dockerfiles/harness/base.fips.Dockerfile
-o harness \
cmd/harness/*.go

FROM registry.access.redhat.com/ubi8/ubi-minimal:latest AS final

Check warning

Code scanning / Trivy

':latest' tag used Medium

Artifact: dockerfiles/harness/base.fips.Dockerfile
Type: dockerfile
Vulnerability DS001
Severity: MEDIUM
Message: Specify a tag in the 'FROM' statement for image 'registry.access.redhat.com/ubi8/ubi-minimal'
Link: DS001
@zreigz zreigz merged commit 47e45e6 into main Nov 6, 2024
36 checks passed
@zreigz zreigz deleted the fips-binary branch November 6, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaeljguarino michaeljguarino michaeljguarino approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zreigz @michaeljguarino @maciaszczykm