Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: metricsaggregate sporadic errors #290

Merged
merged 1 commit into from
Sep 30, 2024
Merged

fix: metricsaggregate sporadic errors #290

merged 1 commit into from
Sep 30, 2024

Conversation

zreigz
Copy link
Member

@zreigz zreigz commented Sep 30, 2024

Replace controller runtime client with dedicated metrics client to avoid resource cache

@zreigz zreigz added the hotfix label Sep 30, 2024
michaeljguarino
michaeljguarino approved these changes Sep 30, 2024
View reviewed changes
Copy link
Member

@michaeljguarino michaeljguarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm guessing the errors was from controller-runtime's auto-caching?

@zreigz
Copy link
Member Author

zreigz commented Sep 30, 2024

yes, it was internal error in client-go cache

@zreigz zreigz merged commit 3833bc1 into main Sep 30, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaeljguarino michaeljguarino michaeljguarino approved these changes

Assignees

@michaeljguarino michaeljguarino

Labels
hotfix size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zreigz @michaeljguarino