feat: metrics aggregate #269
Conversation
zreigz
commented
Sep 17, 2024
•
zreigz
commented
- Implement a controller to reconcile a metrics aggregate.
- Create DebounceReconciler as a wrapper that fulfills the controller-runtime interface. It can be use for every controller to delay requests.
zreigz
force-pushed
the
metrics-aggregate
branch
from
25e905e to
72c4cf1
Compare
| // +kubebuilder:validation:Required | ||
| Spec MetricsAggregateSpec `json:"spec"` | ||
|
|
||
| // Status of the IngressReplica |
There was a problem hiding this comment.
comment for IngressReplica here
| } | ||
|
|
||
| type MetricsAggregateSpec struct { | ||
| Nodes int `json:"nodes"` |
There was a problem hiding this comment.
are these fields optional? Feels like this should probably be the status struct tbh
| fraction = float64(metrics.Spec.MemoryTotalBytes) / float64(metrics.Spec.MemoryAvailableBytes) * 100 | ||
| metrics.Spec.MemoryUsedPercentage = int64(fraction) | ||
|
|
||
| return ctrl.Result{}, reterr |
There was a problem hiding this comment.
shouldn't you be requeueing to update on an interval
|
Another thing we should do is have the agent insert a default metrics aggregate resource on boot (if it doesn't exist). I'm not sure we'll be able to do it in the helm chart smoothly, because of annoying CRD application/validation stuff, but it would be nice to have zero-config guarantees its there so the console server can query it. Can just name the default one as |
The |
|
Expects to bump the chart version |
it's a chart linter that expects to update the version, we do this only for releases |
|
@michaeljguarino can we merge this? |
