Avoid version coercion in components (#73)

Kubernetes will occasionally switch kind versions on apply automatically via mutating webhooks, this is fine, but ruins our ability to detect deprecations in manifests, so revert back to manifest versions where we can find them.

pkg/manifests/versions.go

@@ -0,0 +1,25 @@
+package manifests
+
+import (
+	"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
+)
+
+type GroupName struct {
+	Group string
+	Kind  string
+	Name  string
+}
+
+func VersionCache(manifests []*unstructured.Unstructured) map[GroupName]string {
+	res := map[GroupName]string{}
+	for _, man := range manifests {
+		gvk := man.GroupVersionKind()
+		name := GroupName{
+			Group: gvk.Group,
+			Kind:  gvk.Kind,
+			Name:  man.GetName(),
+		}
+		res[name] = gvk.Version
+	}
+	return res
+}

pkg/sync/loop.go

@@ -6,6 +6,7 @@ import (
 	"runtime/debug"
 	"time"
 
+	manis "github.com/pluralsh/deployment-operator/pkg/manifests"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
 	"sigs.k8s.io/cli-utils/pkg/apply"
@@ -110,6 +111,8 @@ func (engine *Engine) processItem(item interface{}) error {
 		})
 		return engine.UpdatePruneStatus(id, svc.Name, svc.Namespace, ch, len(manifests))
 	}
+
+	vcache := manis.VersionCache(manifests)
 	log.Info("Apply service", "name", svc.Name, "namespace", svc.Namespace)
 	if err := engine.CheckNamespace(svc.Namespace); err != nil {
 		log.Error(err, "failed to check namespace")
@@ -137,7 +140,7 @@ func (engine *Engine) processItem(item interface{}) error {
 		InventoryPolicy:        inventory.PolicyAdoptAll,
 	})
 
-	return engine.UpdateApplyStatus(id, svc.Name, svc.Namespace, ch, false)
+	return engine.UpdateApplyStatus(id, svc.Name, svc.Namespace, ch, false, vcache)
 }
 
 func (engine *Engine) splitObjects(id string, objs []*unstructured.Unstructured) (*unstructured.Unstructured, []*unstructured.Unstructured, error) {

pkg/sync/status.go

@@ -5,6 +5,7 @@ import (
 	"strings"
 
 	console "github.com/pluralsh/console-client-go"
+	"github.com/pluralsh/deployment-operator/pkg/manifests"
 	"github.com/samber/lo"
 	"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
 	"k8s.io/apimachinery/pkg/runtime/schema"
@@ -200,7 +201,7 @@ func FormatActionGroupEvent(age event.ActionGroupEvent) error {
 	return nil
 }
 
-func (engine *Engine) UpdateApplyStatus(id, name, namespace string, ch <-chan event.Event, printStatus bool) error {
+func (engine *Engine) UpdateApplyStatus(id, name, namespace string, ch <-chan event.Event, printStatus bool, vcache map[manifests.GroupName]string) error {
 	var statsCollector stats.Stats
 	var err error
 	components := []*console.ComponentAttributes{}
@@ -261,7 +262,7 @@ func (engine *Engine) UpdateApplyStatus(id, name, namespace string, ch <-chan ev
 	}
 
 	for _, v := range statusCollector.latestStatus {
-		consoleAttr := fromSyncResult(v)
+		consoleAttr := fromSyncResult(v, vcache)
 		if consoleAttr != nil {
 			components = append(components, consoleAttr)
 		}
@@ -274,17 +275,28 @@ func (engine *Engine) UpdateApplyStatus(id, name, namespace string, ch <-chan ev
 	return nil
 }
 
-func fromSyncResult(e event.StatusEvent) *console.ComponentAttributes {
+func fromSyncResult(e event.StatusEvent, vcache map[manifests.GroupName]string) *console.ComponentAttributes {
 	if e.Resource == nil {
 		return nil
 	}
 	gvk := e.Resource.GroupVersionKind()
+	gname := manifests.GroupName{
+		Group: gvk.Group,
+		Kind:  gvk.Kind,
+		Name:  e.Resource.GetName(),
+	}
+
+	version := gvk.Version
+	if v, ok := vcache[gname]; ok {
+		version = v
+	}
+
 	return &console.ComponentAttributes{
 		Group:     gvk.Group,
 		Kind:      gvk.Kind,
 		Namespace: e.Resource.GetNamespace(),
 		Name:      e.Resource.GetName(),
-		Version:   gvk.Version,
+		Version:   version,
 		Synced:    e.PollResourceInfo.Status == status.CurrentStatus,
 		State:     toStatus(e.Resource),
 	}