Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add itemtype, item ans path injection for Database instance #432

Merged
merged 8 commits into from
Nov 29, 2024
Merged

Add itemtype, item ans path injection for Database instance #432

merged 8 commits into from
Nov 29, 2024

Conversation

Lainow
Copy link
Contributor

@Lainow Lainow commented Oct 10, 2024

Checklist before requesting a review

Please delete options that are not relevant.

  • I have performed a self-review of my code.
  • I have added tests (when available) that prove my fix is effective or that my feature works.
  • This change requires a documentation update.

Description

  • It fixes !34742
  • Here is a brief description of what this PR does

Add injection of the item type, item and path for the database instance

Screenshots (if appropriate):

Before
image

After
image

@Lainow Lainow self-assigned this Oct 11, 2024
@AdrienClairembault AdrienClairembault requested review from stonebuzz and Rom1-B and removed request for AdrienClairembault October 11, 2024 11:09
@Lainow Lainow requested a review from stonebuzz October 14, 2024 09:24
@Lainow Lainow force-pushed the fix-databaseinstance-injection branch from a5ca8a3 to 849ffc1 Compare October 14, 2024 09:25
Rom1-B
Rom1-B requested changes Oct 17, 2024
View reviewed changes
inc/databaseinstanceinjection.class.php Outdated Show resolved Hide resolved
inc/databaseinstanceinjection.class.php Outdated Show resolved Hide resolved
@Lainow Lainow requested a review from Rom1-B October 17, 2024 13:29
Rom1-B
Rom1-B requested changes Oct 17, 2024
View reviewed changes
inc/databaseinstanceinjection.class.php Outdated Show resolved Hide resolved
@Lainow Lainow requested a review from Rom1-B November 4, 2024 15:54
Rom1-B
Rom1-B approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@Rom1-B Rom1-B left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK to me.
Apparently, it's linked to a PR core, can you add its link here please?

@Lainow
Copy link
Contributor Author

Lainow commented Nov 5, 2024

Waiting customer feedback

@stonebuzz
Copy link
Contributor

glpi-project/glpi#18053 is merged

@stonebuzz
Copy link
Contributor

@Lainow

seems good for costumer, can you adapt CHANGELOG.md

@stonebuzz
Copy link
Contributor

can you rebase

@stonebuzz stonebuzz merged commit 076858a into pluginsGLPI:main Nov 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rom1-B Rom1-B Rom1-B approved these changes

@stonebuzz stonebuzz stonebuzz approved these changes

Assignees

@Lainow Lainow

Labels
need feedback
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Lainow @stonebuzz @Rom1-B