Clear inputDomain in diffLayout #7283
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| newFullLayout[key].domain = oldFullLayout[key].domain; | ||
| } else if (newDomain[0] !== oldDomain[0] || newDomain[1] !== oldDomain[1]) { | ||
| // what you're asking for HAS changed, so clear _inputDomain and let us start from scratch | ||
| newFullLayout[key]._inputDomain = null; |
There was a problem hiding this comment.
I think nestedProperty(...).set(null) is actually equivalent to delete newFullLayout[key]._inputDomain
There was a problem hiding this comment.
@alexcjohnson Using delete may be slower comparing to setting to null. No?
There was a problem hiding this comment.
I suppose that’s faster and should be equivalent. This is not a high volume operation so I wouldn’t be too concerned about it, but we can leave it if you prefer.
|
@marthacryan Thanks very much for another excellent PR. 🏆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative fix to plotly/plotly.py#4794. Other fix is #7282.
Context:
editTypefrom'calc'to'plot'is more of a downgrade than something that should fix this issue._inputDomain, but that this line was returning indiffFlagsbefore it reached the yaxis to reset it_inputDomainin thechangedfunction was actually incorrect. It should be reset in its own separate crawl of the layout._inputDomaininto thediffLayoutfunction because it has access to both the old layout and the new layout.