Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to go 1.23 + all dependencies to latest dekn#10068 #12

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

agateaux
Copy link

@agateaux agateaux commented Oct 24, 2024

To address https://github.com/plotly/dekn/issues/10068

Golang upgraded to 1.23.
go.mod file has all its dependencies upgraded to latest.
GA tools are also upgraded.

Chartmuseum and Notary have been deprecated upstream, to everything regarding them is removed.

@obanby
Copy link

obanby commented Oct 25, 2024

Thanks @agateaux! This will take sometime to review.

In the future when we pull from upstream, do you foresee any issues with merges or conflicts that might slow us down?

@agateaux
Copy link
Author

agateaux commented Oct 25, 2024

Thanks @agateaux! This will take sometime to review.

In the future when we pull from upstream, do you foresee any issues with merges or conflicts that might slow us down?

Usually yes, I would never have done that if I haven't noticed the upstream had not been updated for 1 year.
IMO, the upstream is not maintained anymore.

There would be conflicts if they keep maintaining Chartmuseum and Notary, and as well keep using the old operator framework.

So maybe this PR could be sent to upstream as well ?

@devinturner
Copy link

There would be conflicts if they keep maintaining Chartmuseum and Notary, and as well keep using the old operator framework.

So maybe this PR could be sent to upstream as well ?

I think so. They are asking for maintainers in the slack channel for this repo. This would be a good opportunity for us to get this repo maintained.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants