Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly globally disable comments in the tests that need it. #1805

Merged

Commits on Sep 2, 2024

  1. Explicitly globally disable comments in the tests that need it.

    In Plone 6.1, when you actively activate plone.app.discussion, we may globally enable comments by default.
    This is when plone/plone.app.discussion#244 gets merged.
    
    We already had eight or so tests that explicitly globally enable comments.
    Now we explicitly globally disable them in two others.
    Then the tests work in Plone 6.0 and 6.1.
    
    See two test failures here for the plone.app.discussion PR:
    https://jenkins.plone.org/job/pull-request-6.1-3.10/311/
    mauritsvanrees committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    2f3462e View commit details
    Browse the repository at this point in the history