Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update link and label to Theming of Classic UI documentation #248

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

stevepiercy
Copy link
Contributor

@stevepiercy stevepiercy commented Dec 4, 2024

See plone/Products.CMFPlone#4054

While working on the documentation, I found a bug in the control panel that should be corrected either in this PR or a related one in the correct repository, if not this one.

The correct link and label are Theming of Classic UI.

Screenshot 2024-12-03 at 7 35 42 PM

@stevepiercy stevepiercy marked this pull request as draft December 4, 2024 03:43
@mister-roboto
Copy link

@stevepiercy thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@stevepiercy stevepiercy marked this pull request as ready for review December 4, 2024 04:10
@stevepiercy
Copy link
Contributor Author

@jenkins-plone-org please run jobs

Copy link

@yurj yurj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for me

@stevepiercy
Copy link
Contributor Author

ping @mauritsvanrees to include in the next Plone release.

I don't know how to release this package, either.

@stevepiercy stevepiercy merged commit 907d61d into master Dec 4, 2024
14 checks passed
@stevepiercy stevepiercy deleted the docs-classic-ui-theming branch December 4, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants